Support internationalization of text inside the website #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Got false positives?Make changes to the global settings spellcheck.json in /artsy/peril-settings. Typos for Project_Files_0.md
Typos for noImplicitAny.md
Typos for files.md
Typos for Basic_Options_6172.md
Lighthouse Scores
|
| Performance | Accessibility | Best Practices | SEO | Progressive Web App |
|---|---|---|---|---|
| 0.87 | 1 | 0.93 | 0.88 | 0.74 |
/en/tsconfig
| Performance | Accessibility | Best Practices | SEO | Progressive Web App |
|---|---|---|---|---|
| 0.9 | 0.97 | 1 | 0.86 | 0.7 |
/docs/handbook/integrating-with-build-tools.html
| Performance | Accessibility | Best Practices | SEO | Progressive Web App |
|---|---|---|---|---|
| 0.93 | 0.93 | 1 | 0.89 | 0.74 |
|
back to green merges 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the nav above: this PR allows code inside React to be translated. Adds the website section to #100
Interesting things because of this:
Bumped node version of this project to minimum of 13, because that is when internationalization was added natively. We don't use any of those APIs yet (maybe never (like dates/number formatters etc) but better to be sure)
I switched form "leet" to "vo". The locales are verified to be real in the i8n code, and well, "leet" isn't an ISO 639-1 code. So I found the one with only 20 language speakers in the world: Volapük
As an aside, I did some work on the code syntax coloring - it now passes the a11y audits on CI.